Quote Originally Posted by chaika View Post
Russian-speaking students of English as a foreign language tend to struggle with the perfect tenses and quite a bit. These learners/speakers tend to use the present perfect more often than not in cases where the present perfect isn't needed, depending on the depth of their knowledge of English. e.g., Have you called me today? vs. Did you call me today?
Does it mean that "Have you called me today?" is wrong? I was taught that the present perfect is used when the time period specified for the action is not finished yet (today, this morning, this year), and the past simple is used when the time period is already in the past (yesterday, last year, one second ago).
So, as I was taught, I shoud say "Have you called me this year?" but "Did you call me a second ago?". Is it correct?